[WEBSITE-877] Refactor requests #60
Conversation
katylouise
commented
Apr 7, 2017
katylouise
commented
- Created separate requests for general urls and opensearch.
- Created separate builders for opensearch and ntriples.
- Created base builder and base request.
| self || super | ||
| end | ||
|
|
||
| # This class always responds to method calls, even those missing. Therefore, respond_to_missing? always returns true. |
| @@ -0,0 +1,60 @@ | |||
| module Parliament | |||
| module Request | |||
| class UrlRequest < Parliament::Request::BaseRequest | |||
There was a problem hiding this comment.
Missing top-level class documentation comment.
| @query_url | ||
| end | ||
|
|
||
| def setup_query_url(search_params) |
| end | ||
| end | ||
|
|
||
| def query_url |
There was a problem hiding this comment.
Use attr_reader to define trivial reader methods.
| return if url.nil? | ||
|
|
||
| request = Parliament::Request::BaseRequest.new(base_url: url, | ||
| headers: { 'Accept' => 'application/opensearchdescription+xml' }) |
There was a problem hiding this comment.
Align the elements of a hash literal if they span more than one line.
Line is too long. [122/120]
|
|
||
| module Parliament | ||
| module Request | ||
| class OpenSearchRequest < Parliament::Request::BaseRequest |
There was a problem hiding this comment.
Missing top-level class documentation comment.
| # @param [Hash] params (optional) additional URI encoded form values to be added to the URI. | ||
| # | ||
| # @return [Parliament::Response] a Parliament::Response object containing all of the nodes returned from the URL. | ||
| def get(params: nil) |
There was a problem hiding this comment.
Assignment Branch Condition size for get is too high. [18.14/15]
Method has too many lines. [11/10]
| # | ||
| # An interesting note for #initialize is that setting base_url on the class, or using the environment variable | ||
| # PARLIAMENT_BASE_URL means you don't need to pass in a base_url. You can pass one anyway to override the | ||
| # environment variable or class parameter. Similarly, headers can be set by either settings the headers on the class, or passing headers in. |
| @@ -0,0 +1,136 @@ | |||
| module Parliament | |||
| module Request | |||
| class BaseRequest | |||
There was a problem hiding this comment.
Missing top-level class documentation comment.
|
|
||
| module Parliament | ||
| module Builder | ||
| class OpenSearchResponseBuilder < Parliament::Builder::BaseResponseBuilder |
There was a problem hiding this comment.
Missing top-level class documentation comment.
katylouise
force-pushed
the
katylouise/website-899_refactor-request
branch
from
46a1a15
to
386ff3e
Compare
…se atom feed from opensearch
| }.freeze | ||
|
|
||
| def initialize(base_url: nil, headers: nil, builder: nil) | ||
| @base_url = Parliament::Request::OpenSearchRequest.get_description(base_url) || self.class.base_url |
There was a problem hiding this comment.
Should we include an ENV lookup like 'OPENSEARCH_DESCRIPTION_URL'?
| @@ -0,0 +1,73 @@ | |||
| module Parliament | |||
| module Request | |||
| class OpenSearchRequest < Parliament::Request::BaseRequest | |||
There was a problem hiding this comment.
Missing top-level class documentation comment.
| headers: { 'Accept' => 'application/opensearchdescription+xml' }) | ||
| xml_response = request.get | ||
|
|
||
| xml_root = REXML::Document.new(xml_response.body).root |
There was a problem hiding this comment.
Just to check - is this still needed with our gem usage? Or should we use our gem too?
| }.freeze | ||
|
|
||
| def initialize(base_url: nil, headers: nil, builder: nil) | ||
| @base_url = Parliament::Request::OpenSearchRequest.get_description(base_url) || self.class.base_url || ENV['OPENSEARCH_DESCRIPTION_URL'] |
