[WEBSITE-899] Removed opensearch builder and request to separate gem. #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Apr 7, 2017
lib/parliament/request.rb
Outdated
| # @attr_reader [String] base_url the base url of our api. (expected: http://example.com - without the trailing slash). | ||
| # @attr_reader [Hash] headers the headers being sent in the request. | ||
| # Namespace for classes and modules that handle http connections. | ||
| # @since 0.7.0 |
There was a problem hiding this comment.
Incorrect indentation detected (column 0 instead of 2).
katylouise
force-pushed
the
katylouise/website-899_split_out_builders
branch
from
e171253
to
d6846a1
Compare
mattrayner
approved these changes
Apr 10, 2017
| @@ -170,8 +170,8 @@ def house_membership_status | |||
| def build_house_membership_status(no_current_seat_incumbency, no_current_house_incumbency, former_lord, former_mp) | |||
| statuses = [] | |||
| statuses << 'Current MP' unless no_current_seat_incumbency | |||
| statuses << 'Lord' unless no_current_house_incumbency | |||
| statuses << 'Former Lord' if former_lord | |||
| statuses << 'Member of the House of Lords' unless no_current_house_incumbency | |||
There was a problem hiding this comment.
We need to look at extracting these into a language file going forward
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.