Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEBSITE-899][WEBSITE-946][WEBSITE-950] Extract components to separate gems. #63

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions lib/parliament.rb
Original file line number Diff line number Diff line change
@@ -1,11 +1,8 @@
require 'net/http'
require 'grom'

require 'parliament/version'
require 'parliament/request'
require 'parliament/response'
require 'parliament/utils'
require 'parliament/decorator'
require 'parliament/builder'

require 'parliament/network_error'
Expand Down
1 change: 0 additions & 1 deletion lib/parliament/builder.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,5 @@ module Parliament
# @since 0.7.0
module Builder
require 'parliament/builder/base_response_builder'
require 'parliament/builder/ntriple_response_builder'
end
end
13 changes: 11 additions & 2 deletions lib/parliament/builder/base_response_builder.rb
Original file line number Diff line number Diff line change
@@ -1,12 +1,21 @@
module Parliament
module Builder
# Base response builder, allowing the user to return the body of an HTTPResponse.
# @since 0.7.5
class BaseResponseBuilder
def initialize(response)
# Creates a new BaseReponseBuilder.
# @param [HTTPResponse] response an HTTP response.
# @param [Module] decorators a namespace which contains modules used to decorate the objects we receive. It is not used directly by the BaseResponseBuilder, but is there for API completeness.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long. [198/120]

def initialize(response:, decorators: nil)
@response = response
_ = decorators
end

# Builds a Parliament::Response::BaseResponse.
#
# @return [Parliament::Response::Base::Response] a Parliament::Response::BaseResponse containing the HTTPResponse.
def build
@response
Parliament::Response::BaseResponse.new(@response)
end
end
end
Expand Down
25 changes: 0 additions & 25 deletions lib/parliament/builder/ntriple_response_builder.rb

This file was deleted.

27 changes: 0 additions & 27 deletions lib/parliament/decorator.rb

This file was deleted.

27 changes: 0 additions & 27 deletions lib/parliament/decorator/constituency_area.rb

This file was deleted.

92 changes: 0 additions & 92 deletions lib/parliament/decorator/constituency_group.rb

This file was deleted.

48 changes: 0 additions & 48 deletions lib/parliament/decorator/contact_point.rb

This file was deleted.

13 changes: 0 additions & 13 deletions lib/parliament/decorator/gender.rb

This file was deleted.

13 changes: 0 additions & 13 deletions lib/parliament/decorator/gender_identity.rb

This file was deleted.

41 changes: 0 additions & 41 deletions lib/parliament/decorator/house.rb

This file was deleted.

48 changes: 0 additions & 48 deletions lib/parliament/decorator/house_incumbency.rb

This file was deleted.

Loading