Add post functionality to parliament-ruby #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented #post on Parliament::Request::BaseRequest + associated tests
houndci-bot
reviewed
Oct 19, 2017
| # @param [String] body (optional) body of the post request. | ||
| # | ||
| # @return [Parliament::Response::BaseResponse] a Parliament::Response::BaseResponse object containing all of the data returned from the URL. | ||
| def post(params: nil, body: nil) |
There was a problem hiding this comment.
Assignment Branch Condition size for post is too high. [21.91/15]
Method has too many lines. [13/10]
| # @param [Hash] params (optional) additional URI encoded form values to be added to the URI. | ||
| # @param [String] body (optional) body of the post request. | ||
| # | ||
| # @return [Parliament::Response::BaseResponse] a Parliament::Response::BaseResponse object containing all of the data returned from the URL. |
| # | ||
| # # url: http://example.com/people/current?limit=10&page=4&lang=en-gb | ||
| # | ||
| # response = request.post({ limit: 10, page: 4, lang: 'en-gb' }, body: {}.to_json) #=> #<Parliament::Response::BaseResponse ...> |
| # response = request.post(body: {}.to_json) #=> #<Parliament::Response::BaseResponse ...> | ||
| # | ||
| # @example HTTP POST request with URI encoded form values | ||
| # request = Parliament::Request::BaseRequest.new(base_url: 'http://example.com/people/current', headers: {'Content': 'application/json', 'Accept': 'application/json'}) |
| # Makes an HTTP POST request and process results into a response. | ||
| # | ||
| # @example HTTP POST request | ||
| # request = Parliament::Request::BaseRequest.new(base_url: 'http://example.com/people/123', headers: {'Content': 'application/json', 'Accept': 'application/json'}) |
bryonywatson1
approved these changes
Oct 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented #post on Parliament::Request::BaseRequest + associated tests