[WEBDEV-390] Add error handling for invalid IDs #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Oct 25, 2017
| @@ -182,7 +182,7 @@ def add_headers(request) | |||
| def handle_errors(net_response) | |||
| case net_response | |||
| when Net::HTTPOK # 2xx Status | |||
| exception_class = Parliament::NoContentResponseError if net_response['Content-Length'] == '0' | |||
| exception_class = Parliament::NoContentResponseError if net_response['Content-Length'] == '0' || !net_response['Content-Length'] | |||
bryonywatson1
force-pushed
the
bryonywatson1/webdev-390_invalid-id-error-handling
branch
from
073fbba
to
c8ce511
Compare
bryonywatson1
force-pushed
the
bryonywatson1/webdev-390_invalid-id-error-handling
branch
from
c8ce511
to
c672287
Compare
houndci-bot
reviewed
Oct 25, 2017
| @@ -182,7 +182,7 @@ def add_headers(request) | |||
| def handle_errors(net_response) | |||
| case net_response | |||
| when Net::HTTPOK # 2xx Status | |||
| exception_class = Parliament::NoContentResponseError if net_response['Content-Length'] == '0' | |||
| exception_class = Parliament::NoContentResponseError if net_response['Content-Length'] == '0' || (net_response['Content-Length'].nil? && net_response.body.nil?) | |||
mattrayner
approved these changes
Oct 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.