Update base_request to properly handle posts #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Nov 6, 2017
| exception_class = Parliament::NoContentResponseError if net_response['Content-Length'] == '0' | ||
| when Net::HTTPClientError # 4xx Status | ||
| exception_class = Parliament::ClientError | ||
| when Net::HTTPServerError # 5xx Status |
| exception_class = Parliament::ServerError | ||
| when Net::HTTPOK # 2xx Status | ||
| exception_class = Parliament::NoContentResponseError if net_response['Content-Length'] == '0' | ||
| when Net::HTTPClientError # 4xx Status |
| exception_class = Parliament::ClientError | ||
| when Net::HTTPServerError # 5xx Status | ||
| exception_class = Parliament::ServerError | ||
| when Net::HTTPOK # 2xx Status |
| api_request.body = body unless body.nil? | ||
| request = Net::HTTP::Post.new( | ||
| endpoint_uri.request_uri, | ||
| 'Content-Type' => 'application/json' |
There was a problem hiding this comment.
Use one level of indentation for parameters following the first line of a multi-line method call.
| add_headers(api_request) | ||
| api_request.body = body unless body.nil? | ||
| request = Net::HTTP::Post.new( | ||
| endpoint_uri.request_uri, |
There was a problem hiding this comment.
Use one level of indentation for parameters following the first line of a multi-line method call.
Indent the first parameter one step more than the start of the previous line.
jennaramdenee
approved these changes
Nov 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.