Add Typheous as our default networking gem #87

mattrayner · 2018-07-09T10:08:25Z

No description provided.

Initial Typhoeus implimentation

coveralls · 2018-07-09T10:10:30Z

Coverage remained the same at 100.0% when pulling 9a87664 on typheous-investigation into 12e42fd on master.

houndci-bot · 2018-07-09T11:03:37Z

lib/parliament/request/base_request.rb

      end
    end
  end
 end
+


Layout/TrailingBlankLines: 1 trailing blank lines detected.

houndci-bot · 2018-07-09T11:03:37Z

lib/parliament/request/base_request.rb

+        if endpoint.query
+          # Returns [ ["key", "value"], ["key", "value"] ]
+          key_value_array = URI.decode_www_form(endpoint.query)
+          key_value_array.map! { |key_value_pair| [ key_value_pair[0].to_sym, key_value_pair[1] ] }


Layout/SpaceInsideArrayLiteralBrackets: Do not use space inside array brackets.

houndci-bot · 2018-07-09T11:03:37Z

lib/parliament/request/base_request.rb

-          exception_class = Parliament::ClientError
-        when Net::HTTPServerError # 5xx Status
-          exception_class = Parliament::ServerError
+      def separate_uri(query_url, query_params, additional_params)


Metrics/MethodLength: Method has too many lines. [11/10]

houndci-bot · 2018-07-09T11:03:37Z

lib/parliament/request/base_request.rb

+                              (response.headers&.[]('Content-Length').nil? && response.body.empty?)
+                          elsif /\A4\w{2}/.match(response.code.to_s) # 4xx Status
+                            Parliament::ClientError
+                          elsif /\A5\w{2}/.match(response.code.to_s) # 5xx Status


Performance/RedundantMatch: Use =~ in places where the MatchData returned by #match will not be used.

houndci-bot · 2018-07-09T11:03:37Z

lib/parliament/request/base_request.rb

+        exception_class = if response.success? # 2xx Status
+                            Parliament::NoContentResponseError if response.headers&.[]('Content-Length') == '0' ||
+                              (response.headers&.[]('Content-Length').nil? && response.body.empty?)
+                          elsif /\A4\w{2}/.match(response.code.to_s) # 4xx Status


Performance/RedundantMatch: Use =~ in places where the MatchData returned by #match will not be used.

houndci-bot · 2018-07-09T11:03:37Z

lib/parliament/request/base_request.rb

-        headers.each do |key, value|
-          request.add_field(key, value)
-        end
+      def headers


Lint/DuplicateMethods: Method Parliament::Request::BaseRequest#headers is defined at both lib/parliament/request/base_request.rb:15 and lib/parliament/request/base_request.rb:183.

houndci-bot · 2018-07-09T11:03:38Z

lib/parliament/request/base_request.rb

-        request = Net::HTTP::Post.new(
-          endpoint_uri.request_uri,
-          'Content-Type' => 'application/json'
+      def post(params: nil, body: nil, timeout: TIMEOUT, connecttimeout: CONNECTTIMEOUT)


Metrics/MethodLength: Method has too many lines. [15/10]

houndci-bot · 2018-07-09T11:03:38Z

lib/parliament/request/base_request.rb

-        net_response = http.start do |h|
-          api_request = Net::HTTP::Get.new(endpoint_uri.request_uri)
-          add_headers(api_request)
+      def get(params: nil, timeout: TIMEOUT, connecttimeout: CONNECTTIMEOUT)


Metrics/MethodLength: Method has too many lines. [14/10]

houndci-bot · 2018-07-09T11:03:38Z

lib/parliament/request/base_request.rb

@@ -7,6 +9,9 @@ module Request
    # @attr_reader [String] base_url the base url of our api. (expected: http://example.com - without the trailing slash).
    # @attr_reader [Hash] headers the headers being sent in the request.
    class BaseRequest
+      TIMEOUT        = 40.freeze
+      CONNECTTIMEOUT = 5.freeze


Style/RedundantFreeze: Do not freeze immutable objects, as freezing them has no effect.

houndci-bot · 2018-07-09T11:03:38Z

lib/parliament/request/base_request.rb

@@ -7,6 +9,9 @@ module Request
    # @attr_reader [String] base_url the base url of our api. (expected: http://example.com - without the trailing slash).
    # @attr_reader [Hash] headers the headers being sent in the request.
    class BaseRequest
+      TIMEOUT        = 40.freeze


Style/RedundantFreeze: Do not freeze immutable objects, as freezing them has no effect.

houndci-bot · 2018-07-09T11:03:38Z

lib/parliament/request/base_request.rb

      end
    end
  end
 end
+


Layout/TrailingBlankLines: 1 trailing blank lines detected.

houndci-bot · 2018-07-09T11:03:39Z

lib/parliament/request/base_request.rb

+        if endpoint.query
+          # Returns [ ["key", "value"], ["key", "value"] ]
+          key_value_array = URI.decode_www_form(endpoint.query)
+          key_value_array.map! { |key_value_pair| [ key_value_pair[0].to_sym, key_value_pair[1] ] }


Layout/SpaceInsideArrayLiteralBrackets: Do not use space inside array brackets.

houndci-bot · 2018-07-09T11:03:39Z

lib/parliament/request/base_request.rb

-          exception_class = Parliament::ClientError
-        when Net::HTTPServerError # 5xx Status
-          exception_class = Parliament::ServerError
+      def separate_uri(query_url, query_params, additional_params)


Metrics/MethodLength: Method has too many lines. [11/10]

houndci-bot · 2018-07-09T11:03:39Z

lib/parliament/request/base_request.rb

+                              (response.headers&.[]('Content-Length').nil? && response.body.empty?)
+                          elsif /\A4\w{2}/.match(response.code.to_s) # 4xx Status
+                            Parliament::ClientError
+                          elsif /\A5\w{2}/.match(response.code.to_s) # 5xx Status


Performance/RedundantMatch: Use =~ in places where the MatchData returned by #match will not be used.

houndci-bot · 2018-07-09T11:03:39Z

lib/parliament/request/base_request.rb

+        exception_class = if response.success? # 2xx Status
+                            Parliament::NoContentResponseError if response.headers&.[]('Content-Length') == '0' ||
+                              (response.headers&.[]('Content-Length').nil? && response.body.empty?)
+                          elsif /\A4\w{2}/.match(response.code.to_s) # 4xx Status


Performance/RedundantMatch: Use =~ in places where the MatchData returned by #match will not be used.

houndci-bot · 2018-07-09T11:03:39Z

lib/parliament/request/base_request.rb

-        headers.each do |key, value|
-          request.add_field(key, value)
-        end
+      def headers


Lint/DuplicateMethods: Method Parliament::Request::BaseRequest#headers is defined at both lib/parliament/request/base_request.rb:15 and lib/parliament/request/base_request.rb:183.

houndci-bot · 2018-07-09T11:03:40Z

lib/parliament/request/base_request.rb

-        request = Net::HTTP::Post.new(
-          endpoint_uri.request_uri,
-          'Content-Type' => 'application/json'
+      def post(params: nil, body: nil, timeout: TIMEOUT, connecttimeout: CONNECTTIMEOUT)


Metrics/MethodLength: Method has too many lines. [15/10]

houndci-bot · 2018-07-09T11:03:40Z

lib/parliament/request/base_request.rb

-        net_response = http.start do |h|
-          api_request = Net::HTTP::Get.new(endpoint_uri.request_uri)
-          add_headers(api_request)
+      def get(params: nil, timeout: TIMEOUT, connecttimeout: CONNECTTIMEOUT)


Metrics/MethodLength: Method has too many lines. [14/10]

houndci-bot · 2018-07-09T11:03:40Z

lib/parliament/request/base_request.rb

@@ -7,6 +9,9 @@ module Request
    # @attr_reader [String] base_url the base url of our api. (expected: http://example.com - without the trailing slash).
    # @attr_reader [Hash] headers the headers being sent in the request.
    class BaseRequest
+      TIMEOUT        = 40.freeze
+      CONNECTTIMEOUT = 5.freeze


Style/RedundantFreeze: Do not freeze immutable objects, as freezing them has no effect.

houndci-bot · 2018-07-09T11:03:40Z

lib/parliament/request/base_request.rb

@@ -7,6 +9,9 @@ module Request
    # @attr_reader [String] base_url the base url of our api. (expected: http://example.com - without the trailing slash).
    # @attr_reader [Hash] headers the headers being sent in the request.
    class BaseRequest
+      TIMEOUT        = 40.freeze


Style/RedundantFreeze: Do not freeze immutable objects, as freezing them has no effect.

cazwazacz · 2018-07-09T11:02:28Z

lib/parliament/request/url_request.rb

@@ -13,7 +13,7 @@ class UrlRequest < Parliament::Request::BaseRequest
      #
      # @param [String] base_url the base url of our api. (expected: http://example.com - without the trailing slash).
      # @param [Hash] headers the headers being sent in the request.
-      # @param [Parliament::Builder] builder the builder to use in order to build a response.
+      # @param [Parliament::Builder] builder the builder to use in order to build a response.{{}}


Curly braces needed?

callumnj and others added 7 commits March 16, 2018 14:05

Initial Typhoeus implimentation

1134107

Merge pull request #86 from C-N-J/c-n-j/integrate_typhoeus

8dd3b95

Initial Typhoeus implimentation

Update typhoeus code

b3bced7

Fix issue with encoded uris

3a98e73

Fix parameter overriding

411c6c3

Fix a URL generation issue

cba0f0a

Add an explicit timeout and connectiontimeout to typhoeus

0cab505

mattrayner added 2 commits July 9, 2018 11:20

Rev version to 1.0

755b8eb

Fix documentation issue

9a87664

houndci-bot reviewed Jul 9, 2018

View reviewed changes

cazwazacz approved these changes Jul 9, 2018

View reviewed changes

mattrayner merged commit 048d47e into master Jul 9, 2018

mattrayner deleted the typheous-investigation branch July 9, 2018 12:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Typheous as our default networking gem #87

Add Typheous as our default networking gem #87

mattrayner commented Jul 9, 2018

coveralls commented Jul 9, 2018 •

edited

houndci-bot Jul 9, 2018

houndci-bot Jul 9, 2018

houndci-bot Jul 9, 2018

houndci-bot Jul 9, 2018

houndci-bot Jul 9, 2018

houndci-bot Jul 9, 2018

houndci-bot Jul 9, 2018

houndci-bot Jul 9, 2018

houndci-bot Jul 9, 2018

houndci-bot Jul 9, 2018

houndci-bot Jul 9, 2018

houndci-bot Jul 9, 2018

houndci-bot Jul 9, 2018

houndci-bot Jul 9, 2018

houndci-bot Jul 9, 2018

houndci-bot Jul 9, 2018

houndci-bot Jul 9, 2018

houndci-bot Jul 9, 2018

houndci-bot Jul 9, 2018

houndci-bot Jul 9, 2018

cazwazacz Jul 9, 2018

Add Typheous as our default networking gem #87

Add Typheous as our default networking gem #87

Conversation

mattrayner commented Jul 9, 2018

coveralls commented Jul 9, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Jul 9, 2018 •

edited