Fixed bug on change group value (#944)

* test #923

* fix

* chlog

* allow npm publish from branch

.github/workflows/npm-publish.yml

@@ -27,8 +27,6 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3
-        with:
-          ref: master
       - uses: pnpm/action-setup@v2
         with:
           version: 7

CHANGELOG.md

@@ -9,6 +9,7 @@
   - 2nd parameter of `onChange` callback now equals original config, not extended config (PR #866) (issue #364)
   - Fix totalQuery structure in mongodb (PR #916) (issue #915)
   - Fixed bug in `loadTree()` (PR #917) (issue #356)
+  - Fixed bug on change group value (PR #944) (issue #923)
 - 6.2.0
   - Fixed type `Config`: should have render settings like `renderSize` (PR #909) (issue #879)
   - Fixed type for `renderBeforeWidget`: `RuleProps` instead of wrong `FieldProps` (PR #909) (issue #879)

packages/core/modules/utils/validation.js

@@ -305,7 +305,7 @@ const validateNormalValue = (leftField, field, value, valueSrc, valueType, async
     const wType = wConfig.type;
     const jsType = wConfig.jsType;
     const fieldSettings = fieldConfig.fieldSettings;
-    const listValues = fieldSettings.treeValues || fieldSettings.listValues;
+    const listValues = fieldSettings?.treeValues || fieldSettings?.listValues;
 
     if (valueType && valueType != wType)
       return [`Value should have type ${wType}, but got value of type ${valueType}`, value];

packages/tests/specs/InteractionsVanilla.test.js

@@ -277,4 +277,21 @@ describe("interactions on vanilla", () => {
     });
   });
 
+  it("change group operator", async () => {
+    await with_qb(configs.with_group_array_cars, inits.with_group_array_cars, "JsonLogic", (qb, onChange) => {
+      qb
+        .find(".rule_group_ext .group--field--count--rule .rule--value .widget--widget input")
+        .simulate("change", { target: { value: 4 } });
+      const changedTree = getTree(onChange.getCall(0).args[0]);
+      const childKeys = Object.keys(changedTree.children1); 
+      expect(childKeys.length).to.equal(1);
+      const child = changedTree.children1[childKeys[0]];
+      expect(child.properties.field).to.equal("cars");
+      expect(child.properties.operator).to.equal("greater");
+      expect(child.properties.conjunction).to.equal("AND");
+      expect(child.properties.value).to.eql([4]);
+    });
+  });
+
 });
+