Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to React 16.x and antd 3.7.0. #44

Closed

Conversation

joskoanicic
Copy link

Updated and changed react-hot-loader to work with latest React.
Updated the font size to 14px to follow the new antd default font size.
Adjusted field width to accommodate the new font size.
Changed multiselect prop to follow the new antd specification.

References issues #40 and #24

There should probably be additional changes to the styling (especially for the compact size).

Updated and changed react-hot-loader to work with latest React.
Updated the font size to 14px to follow the new antd default font size.
Adjusted field width to accommodate the new font size.
Changed multiselect prop to follow the new antd specification.
@joskoanicic
Copy link
Author

Need to find I way to parametrize the react-hot-loader in .babelrc, as it gets included in the published version.
I have stopped using react-hot-loader before some time so I don't know the new best practices for excluding it from production code.

Changing the config in runtime wouldn't update the component. Fixed the componentWillReceiveProps method.
@sitch
Copy link

sitch commented Sep 19, 2018

Also antd is currently at v3.9.2 -- consider bumping to the latest version

Removed react-hot-loader from babel as it wasn't working in production build.
@ukrbublik
Copy link
Owner

@ukrbublik ukrbublik closed this Dec 18, 2018
@Ditofry Ditofry mentioned this pull request Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants