Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded to dependency tree to React 17 and added mui (material-ui v5) widget collection #505

Merged
merged 22 commits into from Feb 2, 2022

Conversation

dilan-dio4
Copy link
Contributor

@dilan-dio4 dilan-dio4 commented Sep 30, 2021

  • Since enzyme-adapter-react-17 deps were incompatible with React 17.0.2, I forked my own version and manually changed the dependency tree. It's currently in package.json with a direct GitHub link.
  • All the test scripts completed successfully, except for the sandbox scripts. I'm not too familiar with sandbox and I was getting a this error:
Failed to compile.

src/demo/config_simple.tsx
  Line 0:  Parsing error: Cannot read file '/.../react-awesome-query-builder/sandbox/sandbox/tsconfig.json'

src/demo/demo.tsx
  Line 0:  Parsing error: Cannot read file '/.../react-awesome-query-builder/sandbox/sandbox/tsconfig.json'

src/index.tsx
  Line 0:  Parsing error: Cannot read file '/.../react-awesome-query-builder/sandbox/sandbox/tsconfig.json'

I'm not familiar with sandbox and maybe it was an issue with my machine. This was the only reason that I could not get npm run smoke to finish successfully, but everything worked other than that aspect.

  • Since @mui/lab also exports @date-io, I had to enable skipLibCheck in tsconfig because of the duplicate interfaces, although they are the same.

  • There does not yet exists a @hot-loader/react-dom for React 17.0.2 yet, so I temporarily commented out that functionality on dev instances.

There's a lot of stuff here an I'm happy to edit stuff as needed. This is an awesome package.


IssueHunt Summary

Referenced issues

This pull request has been submitted to:


@ukrbublik
Copy link
Owner

Thanks for PR.
I haven't checked it yet, but is there another way to support MUI 5 without copying files with changes?
Maybe some kind of template files and script that generates files for v4 and v5

@dilan-dio4
Copy link
Contributor Author

@ukrbublik Good idea. That's probably a better way to do it.

I'll try to put something together.

@ukrbublik ukrbublik added this to To do in kanban Oct 5, 2021
@ukrbublik ukrbublik mentioned this pull request Nov 17, 2021
@dilan-dio4
Copy link
Contributor Author

A couple notes on the changes since this PR first occurred:

Since the new updates to main, I was able to to pass smoke on my machine. This is primarily because of the support for React 17 on main.

Please note that the points from above still exist in this PR due to the fact that MUI v5 supports at a minimum React 17.0.2

Since enzyme-adapter-react-17 deps were incompatible with React 17.0.2, I forked my own version and manually changed the dependency tree. It's currently in package.json with a direct GitHub link.
...
Since @mui/lab also exports @date-io, I had to enable skipLibCheck in tsconfig because of the duplicate interfaces, although they are the same.

There does not yet exists a @hot-loader/react-dom for React 17.0.2 yet, so I temporarily commented out that functionality on dev instances.

@dilan-dio4
Copy link
Contributor Author

Looking into why smoke timed out here but didn't on my machine...

@ukrbublik ukrbublik merged commit ff929c5 into ukrbublik:master Feb 2, 2022
@ukrbublik ukrbublik mentioned this pull request Feb 2, 2022
@ukrbublik
Copy link
Owner

Copied to #628 with fixes
Will release MUI 5 support in 5.0

@ukrbublik ukrbublik moved this from To do to Done in kanban Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants