Enhancement: show baseline, diff, comparison screenshots in single view #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is amazing! I will review shortly and merge! I like the idea of adding more information for the report and upgrading the libraries that we are using! keep the PRs coming! |
PippoRaimondi
approved these changes
Jul 25, 2022
|
🎉 This PR is included in version 1.20.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
kien-ht
deleted the
feat/show-baseline-diff-comparison-screenshots-in-single-view-83
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you're open to it I was also thinking about improving our report, such as updating bootstrap library and showing more information about test suites in general (number of passed or failed tests, .etc). That would be a separate pull request though.
By the way, I don't think that there's any current commit type matching this pull request. It would be nice to have a type of "enhancement"