Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/RR-1336-migrate-ew-wins #5274

Merged
merged 5 commits into from
Mar 26, 2024
Merged

Conversation

chopkinsmade
Copy link
Contributor

@chopkinsmade chopkinsmade commented Mar 20, 2024

Description of change

Add an endpoint for returning the Export wins data inside datahub via a dataset to be consumed in data workspace

Checklist

  • Has this branch been rebased on top of the current main branch?

    Explanation

    The branch should not be stale or have conflicts at the time reviews are requested.

  • Is the CircleCI build passing?

General points

Other things to check

  • Make sure fixtures/test_data.yaml is maintained when updating models
  • Consider the admin site when making changes to models
  • Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
  • Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 96.96970% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 96.46%. Comparing base (637eef8) to head (6c04d28).
Report is 3 commits behind head on main.

Files Patch % Lines
datahub/dataset/export_wins/views.py 94.44% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5274   +/-   ##
=======================================
  Coverage   96.45%   96.46%           
=======================================
  Files         922      922           
  Lines       21836    21866   +30     
  Branches     1947     1954    +7     
=======================================
+ Hits        21063    21094   +31     
+ Misses        626      625    -1     
  Partials      147      147           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chopkinsmade chopkinsmade force-pushed the feature/RR-1336-migrate-ew-wins branch 2 times, most recently from 1ea8768 to 79f8290 Compare March 21, 2024 15:52
@chopkinsmade chopkinsmade force-pushed the feature/RR-1336-migrate-ew-wins branch from aa704a8 to 55f0ff2 Compare March 26, 2024 09:10
@chopkinsmade chopkinsmade marked this pull request as ready for review March 26, 2024 11:02
@chopkinsmade chopkinsmade requested a review from a team as a code owner March 26, 2024 11:02
@chopkinsmade chopkinsmade removed the wip label Mar 26, 2024
@chopkinsmade chopkinsmade merged commit c5ae3e8 into main Mar 26, 2024
4 checks passed
@chopkinsmade chopkinsmade deleted the feature/RR-1336-migrate-ew-wins branch March 26, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants