bugfix/flaky-hvc-EW-test

[chopkinsmade]

Description of change

The financial_year field on the HVC model object is used as part of a unique constraint. By having the factory produce a random number in a small range this can cause a flaky test by having the same financial year generated twice

Checklist

• Has this branch been rebased on top of the current main branch?

  Explanation

  The branch should not be stale or have conflicts at the time reviews are requested.

• Is the CircleCI build passing?

General points

Other things to check

• Make sure fixtures/test_data.yaml is maintained when updating models
• Consider the admin site when making changes to models
• Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
• Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.46%. Comparing base (c5ae3e8) to head (f155d2d).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5291   +/-   ##
=======================================
  Coverage   96.46%   96.46%           
=======================================
  Files         922      922           
  Lines       21853    21853           
  Branches     1953     1954    +1     
=======================================
  Hits        21081    21081           
  Misses        625      625           
  Partials      147      147           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.