Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace lead officer email with contact email for notifications. #5295

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

elcct
Copy link
Contributor

@elcct elcct commented Mar 27, 2024

Description of change

This gets Export win notifications to be sent to lead officer's contact email, rather than email.

Checklist

  • Has this branch been rebased on top of the current main branch?

    Explanation

    The branch should not be stale or have conflicts at the time reviews are requested.

  • Is the CircleCI build passing?

General points

Other things to check

  • Make sure fixtures/test_data.yaml is maintained when updating models
  • Consider the admin site when making changes to models
  • Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
  • Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

@elcct elcct requested a review from a team as a code owner March 27, 2024 11:26
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.45%. Comparing base (8d1968c) to head (a01a575).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5295      +/-   ##
==========================================
- Coverage   96.46%   96.45%   -0.01%     
==========================================
  Files         922      922              
  Lines       21853    21853              
  Branches     1954     1954              
==========================================
- Hits        21081    21079       -2     
- Misses        625      626       +1     
- Partials      147      148       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elcct elcct merged commit 0652e16 into main Mar 27, 2024
4 checks passed
@elcct elcct deleted the fix/lead-officer-contact-email branch March 27, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants