Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/RR-1334-change-empty-strings-to-null-for-EW-wins #5296

Merged

Conversation

chopkinsmade
Copy link
Contributor

@chopkinsmade chopkinsmade commented Mar 27, 2024

Description of change

Added logic to the enrich_data function to change empty string to nulls for some columns that need this inside data-flow

Checklist

  • Has this branch been rebased on top of the current main branch?

    Explanation

    The branch should not be stale or have conflicts at the time reviews are requested.

  • Is the CircleCI build passing?

General points

Other things to check

  • Make sure fixtures/test_data.yaml is maintained when updating models
  • Consider the admin site when making changes to models
  • Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
  • Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 96.45%. Comparing base (823ed78) to head (5537f5a).

Files Patch % Lines
datahub/dataset/export_wins/utils.py 81.81% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5296      +/-   ##
==========================================
- Coverage   96.46%   96.45%   -0.02%     
==========================================
  Files         922      923       +1     
  Lines       21859    21867       +8     
  Branches     1955     1957       +2     
==========================================
+ Hits        21087    21092       +5     
- Misses        625      626       +1     
- Partials      147      149       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chopkinsmade chopkinsmade marked this pull request as ready for review March 27, 2024 15:45
@chopkinsmade chopkinsmade requested a review from a team as a code owner March 27, 2024 15:45
@chopkinsmade chopkinsmade merged commit 01e6d2b into main Mar 28, 2024
3 of 4 checks passed
@chopkinsmade chopkinsmade deleted the feature/RR-1334-change-empty-strings-to-null-for-EW-wins branch March 28, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants