Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/rr 1353 update soft delete undelete status to history #5298

Merged

Conversation

ince-dbt
Copy link
Contributor

@ince-dbt ince-dbt commented Mar 27, 2024

Description of change

This is a small PR about recording soft delete and delete status activity to history and changing current default pagination for win record within the django admin to 10

Checklist

  • Has this branch been rebased on top of the current main branch?

    Explanation

    The branch should not be stale or have conflicts at the time reviews are requested.

  • Is the CircleCI build passing?

General points

Other things to check

  • Make sure fixtures/test_data.yaml is maintained when updating models
  • Consider the admin site when making changes to models
  • Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
  • Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

@ince-dbt ince-dbt requested a review from a team as a code owner March 27, 2024 16:18
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.46%. Comparing base (823ed78) to head (6bab6fc).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5298      +/-   ##
==========================================
- Coverage   96.46%   96.46%   -0.01%     
==========================================
  Files         922      922              
  Lines       21859    21865       +6     
  Branches     1955     1957       +2     
==========================================
+ Hits        21087    21091       +4     
- Misses        625      626       +1     
- Partials      147      148       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

datahub/export_win/admin.py Outdated Show resolved Hide resolved
@ince-dbt ince-dbt force-pushed the feature/RR-1353-update-soft-delete-undelete-status-to-history branch from ee8d464 to 6bab6fc Compare March 28, 2024 09:24
@ince-dbt ince-dbt merged commit a134c6c into main Mar 28, 2024
4 checks passed
@ince-dbt ince-dbt deleted the feature/RR-1353-update-soft-delete-undelete-status-to-history branch March 28, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants