Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/RR-1352-Win-Breakdown #5299

Merged
merged 11 commits into from
Apr 4, 2024

Conversation

ince-dbt
Copy link
Contributor

@ince-dbt ince-dbt commented Mar 27, 2024

Description of change

This PR aims to add relevant breakdown values to total expected export, non export and total odi in win.

Below is further detail in relation to the calculation mentioned abovee:

  • The value in total expected export value should be the total export value in breakdown
  • The value in total expected non export value should be the total business success in breakdown
  • The value in total expected odi value should be the total outward direct investment value in breakdown

The total values of total export, non export and total odi should also get updated whenever the respective values in breakdown change

Checklist

  • Has this branch been rebased on top of the current main branch?

    Explanation

    The branch should not be stale or have conflicts at the time reviews are requested.

  • Is the CircleCI build passing?

General points

Other things to check

  • Make sure fixtures/test_data.yaml is maintained when updating models
  • Consider the admin site when making changes to models
  • Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
  • Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

@ince-dbt ince-dbt requested a review from a team as a code owner March 27, 2024 19:42
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 95.23810% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 96.52%. Comparing base (9a6f54f) to head (73fc837).

Files Patch % Lines
datahub/export_win/admin.py 95.23% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5299      +/-   ##
==========================================
+ Coverage   96.47%   96.52%   +0.04%     
==========================================
  Files         925      925              
  Lines       21931    21943      +12     
  Branches     1963     1962       -1     
==========================================
+ Hits        21158    21180      +22     
+ Misses        625      617       -8     
+ Partials      148      146       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ince-dbt ince-dbt force-pushed the RR-1352-amending-total-export-nonexport-odi branch 12 times, most recently from f515652 to 1717af4 Compare April 2, 2024 17:20
@ince-dbt ince-dbt changed the title [DRAFT] Add calculation to add breakdown value to total export, non export an… Add calculation to add breakdown value to total export, non export and ODI Apr 2, 2024
@ince-dbt ince-dbt changed the title Add calculation to add breakdown value to total export, non export and ODI add breakdown values automatically to total export, non export and ODI Apr 2, 2024
@ince-dbt ince-dbt changed the title add breakdown values automatically to total export, non export and ODI Add breakdown values automatically to total export, non export and ODI Apr 2, 2024
@ince-dbt ince-dbt changed the title Add breakdown values automatically to total export, non export and ODI Feature/RR-RR-1352-Add breakdown values automatically to total export, non export and ODI Apr 2, 2024
@ince-dbt ince-dbt changed the title Feature/RR-RR-1352-Add breakdown values automatically to total export, non export and ODI Feature/RR-RR-1352-Win-Breakdown Apr 2, 2024
@ince-dbt ince-dbt changed the title Feature/RR-RR-1352-Win-Breakdown Feature/RR-1352-Win-Breakdown Apr 3, 2024
@ince-dbt ince-dbt force-pushed the RR-1352-amending-total-export-nonexport-odi branch from 32c9419 to fe275c1 Compare April 3, 2024 12:13
@ince-dbt ince-dbt force-pushed the RR-1352-amending-total-export-nonexport-odi branch from e481735 to aa7f38e Compare April 3, 2024 13:56
datahub/export_win/models.py Outdated Show resolved Hide resolved
datahub/export_win/models.py Outdated Show resolved Hide resolved
datahub/export_win/models.py Outdated Show resolved Hide resolved
datahub/export_win/models.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 95.23810% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 96.53%. Comparing base (9a6f54f) to head (f024635).
Report is 1 commits behind head on main.

Files Patch % Lines
datahub/export_win/admin.py 95.23% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5299      +/-   ##
==========================================
+ Coverage   96.47%   96.53%   +0.05%     
==========================================
  Files         925      925              
  Lines       21931    21943      +12     
  Branches     1963     1962       -1     
==========================================
+ Hits        21158    21182      +24     
+ Misses        625      616       -9     
+ Partials      148      145       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ince-dbt ince-dbt force-pushed the RR-1352-amending-total-export-nonexport-odi branch from 198ff70 to c868050 Compare April 3, 2024 16:54
@ince-dbt ince-dbt force-pushed the RR-1352-amending-total-export-nonexport-odi branch from c868050 to d1e55ad Compare April 3, 2024 17:07
@ince-dbt ince-dbt merged commit 7d04233 into main Apr 4, 2024
2 checks passed
@ince-dbt ince-dbt deleted the RR-1352-amending-total-export-nonexport-odi branch April 4, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants