Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/RR-1334-map-DH-export-experience-in-dataset #5302

Merged

Conversation

chopkinsmade
Copy link
Contributor

@chopkinsmade chopkinsmade commented Mar 28, 2024

Description of change

Map the datahub export experience to the export wins equivalent text for consistency when importing into data flow via the datasets endpoint

Checklist

  • Has this branch been rebased on top of the current main branch?

    Explanation

    The branch should not be stale or have conflicts at the time reviews are requested.

  • Is the CircleCI build passing?

General points

Other things to check

  • Make sure fixtures/test_data.yaml is maintained when updating models
  • Consider the admin site when making changes to models
  • Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
  • Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.46%. Comparing base (01e6d2b) to head (741d05f).
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5302   +/-   ##
=======================================
  Coverage   96.46%   96.46%           
=======================================
  Files         923      924    +1     
  Lines       21873    21888   +15     
  Branches     1959     1960    +1     
=======================================
+ Hits        21100    21115   +15     
  Misses        625      625           
  Partials      148      148           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chopkinsmade chopkinsmade marked this pull request as ready for review March 28, 2024 12:01
@chopkinsmade chopkinsmade requested a review from a team as a code owner March 28, 2024 12:01
@chopkinsmade chopkinsmade merged commit 7e5ada0 into main Apr 2, 2024
4 checks passed
@chopkinsmade chopkinsmade deleted the feature/RR-1334-map-DH-export-experience-in-dataset branch April 2, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants