Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/RR-1353 Add version comment when win record created and updated #5312

Merged

Conversation

ince-dbt
Copy link
Contributor

@ince-dbt ince-dbt commented Apr 2, 2024

Description of change

This PR intends to add version comments when win record is created and updated via serializers.

Checklist

  • Has this branch been rebased on top of the current main branch?

    Explanation

    The branch should not be stale or have conflicts at the time reviews are requested.

  • Is the CircleCI build passing?

General points

Other things to check

  • Make sure fixtures/test_data.yaml is maintained when updating models
  • Consider the admin site when making changes to models
  • Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
  • Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

@ince-dbt ince-dbt requested a review from a team as a code owner April 2, 2024 10:12
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.46%. Comparing base (faa254d) to head (4278337).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5312      +/-   ##
==========================================
- Coverage   96.47%   96.46%   -0.01%     
==========================================
  Files         925      925              
  Lines       21906    21909       +3     
  Branches     1961     1961              
==========================================
+ Hits        21133    21134       +1     
- Misses        625      626       +1     
- Partials      148      149       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ince-dbt ince-dbt changed the title Add version comment when win record created and updated feature/RR-1353 Add version comment when win record created and updated Apr 2, 2024
@ince-dbt ince-dbt force-pushed the feature/RR-1353-add-revision-comment-when-win-created-updated branch from 87ce6fc to 3b2c5a3 Compare April 2, 2024 14:21
@ince-dbt ince-dbt changed the title feature/RR-1353 Add version comment when win record created and updated Feature/RR-1353 Add version comment when win record created and updated Apr 2, 2024
@ince-dbt ince-dbt force-pushed the feature/RR-1353-add-revision-comment-when-win-created-updated branch from 3b2c5a3 to 4278337 Compare April 3, 2024 10:37
@ince-dbt ince-dbt merged commit 65d7592 into main Apr 3, 2024
4 checks passed
@ince-dbt ince-dbt deleted the feature/RR-1353-add-revision-comment-when-win-created-updated branch April 3, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants