Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add export experience field to public Export Wins endpoint. #5323

Merged

Conversation

elcct
Copy link
Contributor

@elcct elcct commented Apr 3, 2024

Description of change

This adds export_experience field to public facing Export Wins endpoint.

Checklist

  • Has this branch been rebased on top of the current main branch?

    Explanation

    The branch should not be stale or have conflicts at the time reviews are requested.

  • Is the CircleCI build passing?

General points

Other things to check

  • Make sure fixtures/test_data.yaml is maintained when updating models
  • Consider the admin site when making changes to models
  • Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
  • Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

@elcct elcct requested a review from a team as a code owner April 3, 2024 10:21
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.47%. Comparing base (faa254d) to head (6e536e7).

❗ Current head 6e536e7 differs from pull request most recent head 4656cbd. Consider uploading reports for the commit 4656cbd to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5323   +/-   ##
=======================================
  Coverage   96.47%   96.47%           
=======================================
  Files         925      925           
  Lines       21906    21907    +1     
  Branches     1961     1961           
=======================================
+ Hits        21133    21134    +1     
  Misses        625      625           
  Partials      148      148           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elcct elcct force-pushed the feature/add-export-experience-field-to-export-win-endpoint branch from 6e536e7 to 4656cbd Compare April 3, 2024 10:56
@elcct elcct merged commit 25ca1bc into main Apr 3, 2024
2 checks passed
@elcct elcct deleted the feature/add-export-experience-field-to-export-win-endpoint branch April 3, 2024 11:09
@elcct elcct restored the feature/add-export-experience-field-to-export-win-endpoint branch April 3, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants