Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix company contact and cdms reference in Win dataset endpoint. #5328

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

elcct
Copy link
Contributor

@elcct elcct commented Apr 3, 2024

Description of change

Current dataset endpoint for Win gets contact from legacy fields, which is incorrect.
It also needs to get company number if cdms_reference doesn't exist.

Checklist

  • Has this branch been rebased on top of the current main branch?

    Explanation

    The branch should not be stale or have conflicts at the time reviews are requested.

  • Is the CircleCI build passing?

General points

Other things to check

  • Make sure fixtures/test_data.yaml is maintained when updating models
  • Consider the admin site when making changes to models
  • Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
  • Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

@elcct elcct requested a review from a team as a code owner April 3, 2024 19:11
@elcct elcct merged commit e7b3721 into main Apr 4, 2024
2 checks passed
@elcct elcct deleted the fix/win-dataset-endpoint branch April 4, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants