Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/RR-1358-custom-export-wins-admin-search #5330

Merged
merged 8 commits into from
Apr 4, 2024

Conversation

chopkinsmade
Copy link
Contributor

@chopkinsmade chopkinsmade commented Apr 4, 2024

Description of change

Some of the fields that the export wins admin users want to search on are written as python properties that combine multiple fields, however the admin searching functionality can only search on model fields that are stored in the DB. This change annotates the default queryset with some Concat functions that are run as SQL queries

Added an extra export win into the test data

Checklist

  • Has this branch been rebased on top of the current main branch?

    Explanation

    The branch should not be stale or have conflicts at the time reviews are requested.

  • Is the CircleCI build passing?

General points

Other things to check

  • Make sure fixtures/test_data.yaml is maintained when updating models
  • Consider the admin site when making changes to models
  • Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
  • Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

@chopkinsmade chopkinsmade marked this pull request as ready for review April 4, 2024 15:24
@chopkinsmade chopkinsmade requested a review from a team as a code owner April 4, 2024 15:24
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.53%. Comparing base (57fa0bc) to head (eabb0bd).

❗ Current head eabb0bd differs from pull request most recent head 58dcacb. Consider uploading reports for the commit 58dcacb to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5330   +/-   ##
=======================================
  Coverage   96.53%   96.53%           
=======================================
  Files         925      925           
  Lines       21950    21955    +5     
  Branches     1963     1963           
=======================================
+ Hits        21189    21194    +5     
  Misses        616      616           
  Partials      145      145           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chopkinsmade chopkinsmade merged commit decf865 into main Apr 4, 2024
2 checks passed
@chopkinsmade chopkinsmade deleted the feature/RR-1358-custom-export-wins-admin-search branch April 4, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants