Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wins dataset endpoint for responded_on and sector. #5331

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

elcct
Copy link
Contributor

@elcct elcct commented Apr 4, 2024

Description of change

This ensures that when customer_response__responded_on is null, the customer response properties are also null in the dataset.

It also corrects the sector_display so that it returns the entire sector, not just the segment.

Checklist

  • Has this branch been rebased on top of the current main branch?

    Explanation

    The branch should not be stale or have conflicts at the time reviews are requested.

  • Is the CircleCI build passing?

General points

Other things to check

  • Make sure fixtures/test_data.yaml is maintained when updating models
  • Consider the admin site when making changes to models
  • Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
  • Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

@elcct elcct requested a review from a team as a code owner April 4, 2024 15:19
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.52%. Comparing base (7d04233) to head (a34a5ce).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5331   +/-   ##
=======================================
  Coverage   96.52%   96.52%           
=======================================
  Files         925      925           
  Lines       21947    21947           
  Branches     1962     1962           
=======================================
+ Hits        21184    21185    +1     
  Misses        617      617           
+ Partials      146      145    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elcct elcct merged commit d2a0aa9 into main Apr 4, 2024
2 checks passed
@elcct elcct deleted the fix/customer-response-dataset branch April 4, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants