Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RR-1350-Export-win-admin-audit-field-validation #5342

Merged
merged 2 commits into from
Apr 9, 2024

Conversation

ince-dbt
Copy link
Contributor

@ince-dbt ince-dbt commented Apr 8, 2024

Description of change

This is a tiny PR to set audit field to be mandatory and code refactor for read only fields

Checklist

  • Has this branch been rebased on top of the current main branch?

    Explanation

    The branch should not be stale or have conflicts at the time reviews are requested.

  • Is the CircleCI build passing?

General points

Other things to check

  • Make sure fixtures/test_data.yaml is maintained when updating models
  • Consider the admin site when making changes to models
  • Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
  • Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

@ince-dbt ince-dbt requested a review from a team as a code owner April 8, 2024 15:17
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.54%. Comparing base (b261ba9) to head (4c950ae).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5342   +/-   ##
=======================================
  Coverage   96.54%   96.54%           
=======================================
  Files         926      926           
  Lines       21971    21964    -7     
  Branches     1965     1962    -3     
=======================================
- Hits        21211    21206    -5     
  Misses        616      616           
+ Partials      144      142    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ince-dbt ince-dbt changed the title Set audit field to be mandatory RR-1350-set audit field to be mandatory Apr 8, 2024
@ince-dbt ince-dbt changed the title RR-1350-set audit field to be mandatory RR-1350-Export-win-admin-audit-field-validation Apr 8, 2024
@ince-dbt ince-dbt merged commit 46eaeb8 into main Apr 9, 2024
2 checks passed
@ince-dbt ince-dbt deleted the feature/RR-1350-set-audit-field-to-be-mandatory branch April 9, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants