Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log Bad Requests to Export Win endpoints. #5350

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

elcct
Copy link
Contributor

@elcct elcct commented Apr 9, 2024

Description of change

This should let us debug instances of 400 Bad Request returned to the client much easier.
The decorator will log 400 error for post and patch methods of Export Wins endpoint.

Checklist

  • Has this branch been rebased on top of the current main branch?

    Explanation

    The branch should not be stale or have conflicts at the time reviews are requested.

  • Is the CircleCI build passing?

General points

Other things to check

  • Make sure fixtures/test_data.yaml is maintained when updating models
  • Consider the admin site when making changes to models
  • Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
  • Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

@elcct elcct requested a review from a team as a code owner April 9, 2024 12:55
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 95.23810% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 96.53%. Comparing base (b261ba9) to head (d70d897).

Files Patch % Lines
datahub/export_win/views.py 95.23% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5350      +/-   ##
==========================================
- Coverage   96.54%   96.53%   -0.01%     
==========================================
  Files         926      926              
  Lines       21971    21991      +20     
  Branches     1965     1966       +1     
==========================================
+ Hits        21211    21230      +19     
  Misses        616      616              
- Partials      144      145       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elcct elcct merged commit 4f00835 into main Apr 9, 2024
2 checks passed
@elcct elcct deleted the feature/log-bad-request-for-export-win branch April 9, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants