Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PFM-141 Add selenium #100

Merged
merged 1 commit into from
Jul 12, 2021
Merged

PFM-141 Add selenium #100

merged 1 commit into from
Jul 12, 2021

Conversation

SamDudley
Copy link
Contributor

No description provided.

@SamDudley SamDudley force-pushed the PFM-141 branch 4 times, most recently from aac49f1 to 0201cd5 Compare July 12, 2021 13:35
config/settings/test.py Show resolved Hide resolved
@@ -126,6 +126,7 @@
WAGTAIL_APPS = [
"modelcluster",
"taggit",
"wagtail.contrib.search_promotions",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

required to fix tests
wagtail/wagtail#1824

def get_home_page(self):
self.driver.get(URL)

from .homepage import HomePage
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too sure on the imports in the method but this is a easy pattern to avoid the inevitable circular imports.

Copy link
Contributor

@rossmiller rossmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@SamDudley SamDudley merged commit 51d2267 into master Jul 12, 2021
@SamDudley SamDudley deleted the PFM-141 branch July 12, 2021 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants