Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noticket/setup package update #26

Merged
merged 1 commit into from
Oct 6, 2020
Merged

Conversation

fericsepi
Copy link
Contributor

@fericsepi fericsepi commented Oct 5, 2020

To do (delete all that do not apply):

  • Change has a jira ticket that has the correct status.
  • Changelog entry added.
  • (if there are vulnerable requirements) Upgraded any vulnerable dependencies.
  • (if updating requirements) Requirements have been compiled.
  • (if adding env vars) Added any new environment variable to vault.
  • (if adding feature flags) Cleaned up old flags

@fericsepi fericsepi force-pushed the NOTICKET/setup-package-update branch from d331d4c to f116f71 Compare October 6, 2020 07:40
@codecov
Copy link

codecov bot commented Oct 6, 2020

Codecov Report

Merging #26 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #26   +/-   ##
=======================================
  Coverage   99.08%   99.08%           
=======================================
  Files           9        9           
  Lines         438      438           
=======================================
  Hits          434      434           
  Misses          4        4           
Impacted Files Coverage Δ
directory_client_core/helpers.py 100.00% <100.00%> (ø)
tests/test_helpers.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b70e344...f116f71. Read the comment docs.

@depsiatwal depsiatwal merged commit 3ab49cf into master Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants