[CMS-1254] Change blank country choice to "Choose a country" #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #187 +/- ##
=======================================
Coverage 99.36% 99.36%
=======================================
Files 10 10
Lines 469 469
=======================================
Hits 466 466
Misses 3 3
Continue to review full report at Codecov.
|
eadpearce
approved these changes
May 8, 2019
richtier
previously requested changes
May 8, 2019
setup.py
Outdated
| @@ -3,7 +3,7 @@ | |||
|
|
|||
| setup( | |||
| name='directory_components', | |||
| version='10.8.3', | |||
| version='10.8.4', | |||
There was a problem hiding this comment.
master is already at version 11 :)
https://github.com/uktrade/directory-components/blob/master/setup.py#L6
need to update the base branch
sdonk
reviewed
May 8, 2019
CHANGELOG.md
Outdated
|
|
||
| ### Bug fixes: | ||
|
|
||
| - Changed default country selector text to "Select a country" |
There was a problem hiding this comment.
Can you please add the Jira ticket number:
- CMS-1245
sdonk
force-pushed
the
1254-change-blank-country-choice
branch
from
e512df8
to
559f8a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.