Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New fab landing page #373

Merged
merged 4 commits into from Mar 14, 2019
Merged

New fab landing page #373

merged 4 commits into from Mar 14, 2019

Conversation

richtier
Copy link
Contributor

@richtier richtier commented Mar 12, 2019

@richtier richtier changed the title New fab landing page [DNM] New fab landing page Mar 12, 2019
@richtier richtier changed the title [DNM] New fab landing page New fab landing page Mar 12, 2019
enrolment/templates/landing-page.html Outdated Show resolved Hide resolved
enrolment/templates/landing-page.html Outdated Show resolved Hide resolved
</section>
</div>
<div id="fabhome-benefits" class="container with-flag">
<div class="grid-row">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i added a shortcut for this to elements. instead of having to do grid-row then column-blah you can just have one div with a width-half class since it's only one column. deets here https://directory-components-dev.herokuapp.com/elements/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems it's not a like-for-like replacement

image

(notice the padding and margin woes)

was I using the class wrong? I did

	<div class="container fabhome-intro-container">
		<section id="fabhome-intro" class="width-half">
			<h1 class="heading-xlarge">Connect directly with international buyers</h1>
			<p>Create a business profile on great.gov.uk.</p>
			<a class="button" href="{{ enrolment_url }}" title="click to register">Create an account</a>
		</section>
	</div>

enrolment/templates/landing-page.html Show resolved Hide resolved
</div>
<div class="fabhome-bottom-container">
<div class="container">
<section id="fabhome-bottom" class="grid-row">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same again here. it's just one column so you can use a width- class

@codecov-io
Copy link

codecov-io commented Mar 14, 2019

Codecov Report

Merging #373 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #373   +/-   ##
=======================================
  Coverage   97.61%   97.61%           
=======================================
  Files          22       22           
  Lines        1214     1214           
=======================================
  Hits         1185     1185           
  Misses         29       29

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9df144c...f91ff3e. Read the comment docs.

@richtier richtier merged commit f6df6db into master Mar 14, 2019
@richtier richtier deleted the TT-1073-fab-landing-page branch March 14, 2019 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants