New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New fab landing page #373
New fab landing page #373
Conversation
</section> | ||
</div> | ||
<div id="fabhome-benefits" class="container with-flag"> | ||
<div class="grid-row"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i added a shortcut for this to elements. instead of having to do grid-row
then column-blah
you can just have one div with a width-half
class since it's only one column. deets here https://directory-components-dev.herokuapp.com/elements/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems it's not a like-for-like replacement
(notice the padding and margin woes)
was I using the class wrong? I did
<div class="container fabhome-intro-container">
<section id="fabhome-intro" class="width-half">
<h1 class="heading-xlarge">Connect directly with international buyers</h1>
<p>Create a business profile on great.gov.uk.</p>
<a class="button" href="{{ enrolment_url }}" title="click to register">Create an account</a>
</section>
</div>
</div> | ||
<div class="fabhome-bottom-container"> | ||
<div class="container"> | ||
<section id="fabhome-bottom" class="grid-row"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same again here. it's just one column so you can use a width-
class
Codecov Report
@@ Coverage Diff @@
## master #373 +/- ##
=======================================
Coverage 97.61% 97.61%
=======================================
Files 22 22
Lines 1214 1214
=======================================
Hits 1185 1185
Misses 29 29 Continue to review full report at Codecov.
|
this task