This repository has been archived by the owner on May 17, 2019. It is now read-only.
ED-3230 header footer css #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richtier
suggested changes
Feb 1, 2018
| @@ -0,0 +1,15 @@ | |||
|
|
|||
There was a problem hiding this comment.
overrides is for overriding existing library files. It looks like govuk_frontend_toolkit does not contain a file called _layout.scss.
ah, I think the intention is to override the govuk_elements file - so this file should be under govuk_elements, rather than govuk_frontend_toolkit.
|
|
||
| // govuk template | ||
|
|
||
| @import 'elements/govuk-template-base'; |
There was a problem hiding this comment.
I've not documented this yet, and it's very implicit - but files in overrides should "inherit" the file they're overriding
so this should be @import "!elements/layout"
(note the prefix of ! tells out custom sass importer to import the library file, rather than our override.)
…-elements into ED-3230-header-footer-css
richtier
approved these changes
Feb 5, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://uktrade.atlassian.net/browse/ED-3230