[LTD-775] Session Termination #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alixedi
force-pushed
the
LTD-775-session-termination
branch
9 times, most recently
from
135b853
to
009e252
Compare
alixedi
force-pushed
the
LTD-775-session-termination
branch
2 times, most recently
from
d5e621a
to
6c69c7a
Compare
r4vi
reviewed
Apr 16, 2021
r4vi
approved these changes
Apr 16, 2021
|
only one small comment from me, not required to merge but up to you... |
alixedi
force-pushed
the
LTD-775-session-termination
branch
from
6c69c7a
to
fb0a01a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During pen tests, we found that even when a user account was terminated on the SSO, the user would still be able to access LITE using browser cookies.
Other DIT services get around this by using introspection middleware. This middleware hits the introspection endpoint on the SSO service and caches the response for a small amount of time.
We are doing something very similar for LITE.
P.S. It's not introspection technically because we are not using the
/o/introspectendpoint from the SSO service. In the case ofstaff-sso, it is because this endpoint requires a different token. For the case ofdirectory-sso, I haven't been able to find an endpoint for introspection.