Fix countersign review. #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alixedi
force-pushed
the
LTD-1231-fix-countersign-review
branch
3 times, most recently
from
6cb8ac0
to
72a0c9f
Compare
alixedi
force-pushed
the
LTD-1231-fix-countersign-review
branch
from
72a0c9f
to
0644a00
Compare
alixedi
force-pushed
the
LTD-1231-fix-countersign-review
branch
from
0644a00
to
a0f9503
Compare
saruniitr
reviewed
Dec 1, 2021
| @@ -14,6 +14,6 @@ | |||
| path("countersign/", views.CountersignAdviceView.as_view(), name="countersign_advice_view"), | |||
| path("countersign/review-advice/", views.ReviewCountersignView.as_view(), name="countersign_review"), | |||
| path("countersign/view-advice/", views.ViewCountersignedAdvice.as_view(), name="countersign_view"), | |||
| path("countersign/edit-advice", views.CountersignEditAdviceView.as_view(), name="countersign_edit"), | |||
| path("countersign/edit-advice/", views.CountersignEditAdviceView.as_view(), name="countersign_edit"), | |||
saruniitr
approved these changes
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A case with e.g. 2 destinations and 2 goods, has 4 distinct advice-subjects.
As a result, when we save
approval-allorrefuse-alladvice, we create 4 advice records - one for each subject and send it to the API.P.S. This is important and will come in handy when we tackle variable advice.
The flip side to this is that e.g. the countersigner is having to process advice for each subject separately whereas according to the designs, he/she should be able to process the advice from a given advisor as a whole.
What we need to do is to somehow group advice from the same user but different destinations and products into the same block for the purpose of countersigning.
This PR fixes this & hopefully improves on a few other minor things E.g. -
advice_detailsthat does both approvals and refusals. I am hoping that in another PR, I will be able to get rid ofapproval-advice-details&refusal-advice-detailsentirely.countersign_view. Before this PR,countersign_reviewwas being used for this but looking at the code, it seemed like not much was common.