feat: allow disabling of zip64 #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to allow stream-unzip to be used in the testing of libraries that should make zip32 files for compatibility reasons. Note that at the time of writing zip64 support is not ubiquitous. For example, Libre Office doesn't seem to support files zipped with zip64, and Safari seems to have an issue where if the first file from an zip is zip64, it _only_ unzips that one. So while this is a niche feature, it's still a useful one in some circumstances - to test that certain files really are zip32.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to allow stream-unzip to be used in the testing of libraries that should make zip32 files for compatibility reasons.
Note that at the time of writing zip64 support is not ubiquitous. For example, Libre Office doesn't seem to support files zipped with zip64, and Safari seems to have an issue where if the first file from an zip is zip64, it only unzips that one. So while this is a niche feature, it's still a useful one in some circumstances - to test that certain files really are zip32.