feat!: rename constants #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is for clarity, and to allow in future having both NO_COMPRESSION_32 and NO_COMPRESSION_64, to allow clients to fully specify that they do not want any _64 code data. Note that LibreOffice doesn't support zip64 at the time of writing, so this is still an issue. This is not just for "legacy" software.
michalc
force-pushed
the
rename-constants
branch
from
d2ff440
to
390ce3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for clarity, and to allow in future having both NO_COMPRESSION_32 and NO_COMPRESSION_64, to allow clients to fully specify that they do not want any _64 code data.
Note that LibreOffice doesn't support zip64 at the time of writing, so this is still an issue. This is not just for "legacy" software.