Comments and simplifications. #531
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…string properties.
…_invalid if business rules are violated.
simonwo
reviewed
Apr 12, 2022
Comment on lines
834
to
+842
| def condition_string(self) -> str: | ||
| out: list[str] = [] | ||
| """ | ||
| Returns a string representation of the component conditions. | ||
|
|
||
| components = self.components.latest_approved() | ||
| This is the duty_sentence, if there is one measure, measure_type and additional_code or | ||
| if there are more than one measure_type and additional_code. | ||
|
|
||
| :dependencies: with_duty_sentence must be called in queries using this property. | ||
| """ |
There was a problem hiding this comment.
Is this method even used anywhere? I've never really understood what it is meant to be showing?
simonwo
reviewed
Apr 12, 2022
|
|
||
| components = self.components.latest_approved() |
There was a problem hiding this comment.
current() would be better, to take account of any draft data.
gabelton
reviewed
Apr 21, 2022
| if form.is_valid() and not self.form_violates(form): | ||
| return self.form_valid(form) | ||
| else: | ||
| return self.form_invalid(form) |
There was a problem hiding this comment.
So instead of overriding form_valid (which also calls form_invalid) on TrackedModelChangeView should we instead override the post call do you think?
There was a problem hiding this comment.
Probably - at the moment I was getting a load of test failures with this change, I need to get past.
Though, this may be another issue as since I re-setup my env again, I noticed I am getting them in plain master now :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are extra comments + simplifications found looking at TP2000-169, but that weren't actually part of that PR.
Currently encompasses comments for signposting (bits where I was wondering "what does this do and why") along possibly more controversial changes (stopping form_valid call form_invalid, which feels like an API violation).