-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NullPointerExceptions killing ToeThreads #16
Comments
So, re-using the |
Note that my multi-threaded |
Re-running the domain crawl now and fortunately the slow-down seems fairly minor. However, #ToeThreads still not stable. After a day of crawling 27 of 1,600 ToeThreads have died. |
Oh dear, still not got it:
|
Hmm, there are other points where It does seem that the rate of ToeThread death is somewhat slower than before, but it's hard to remember and Prometheus appears not to have discarded the old from the last run, somehow. |
Looking back at older logs, the thread death rate was much worse before (e.g. around 30 out of 100 ToeThreads suffered a fatal error in the first day of the crawl). So these changes do appear to have helped, but some other part of the code is still interfering. |
Okay, this appears to be resolved by internetarchive/heritrix3#213 so closing here, may take longer to close upstream. |
We're seeing really odd fatal errors, killing off ToeThreads in crawls:
Looking at the code, this shouldn't really be possible!
Going up the call tree, it appears the
peekItem
has become inconsistent with, i.e. reset tonull
.Note that NetArchive Suite have also seen this issue and patched it in this way.
Also observing
So, what seems to be happening, I think, is that occasionally, between this statement and this one, the
WorkQueue
gets updated by a separate thread in a way that forces it to get written out to disk and then read back in again. AspeekItem
istransient
, flushing it out to the disk and back drops the value and we're left with anull
.The text was updated successfully, but these errors were encountered: