Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The new site needs a BETA banner #31

Closed
anjackson opened this issue Nov 1, 2017 · 4 comments
Closed

The new site needs a BETA banner #31

anjackson opened this issue Nov 1, 2017 · 4 comments

Comments

@anjackson
Copy link
Contributor

anjackson commented Nov 1, 2017

Could we implement something like the attached mock-up to make it clear that this is the beta? It’s also an opportunity to retain the survey link after they’ve dismissed the popup.

untitled-1

(also the old Access Tool needs a banner pointing users to the new site, but that must be done after this ticket.)

@anjackson anjackson added this to the 1.0.0 Marshmallow Release milestone Nov 1, 2017
@ldbiz
Copy link
Collaborator

ldbiz commented Nov 1, 2017

@min2ha connected job: #21

The survey link in the banner should not be displayed if the user has filled out the survey (or if its not possible to detect that, then if the user has clicked on the survey link).

ie.:

  1. Survey pop up not responded to: Display the link,
  2. Survey dismissed without being filled out: Display the link.
  3. Survey filled out: Don't display the link.

The banner will always be displayed while the application is in Beta.

@ldbiz ldbiz mentioned this issue Nov 1, 2017
min2ha added a commit that referenced this issue Nov 2, 2017
@ldbiz
Copy link
Collaborator

ldbiz commented Nov 2, 2017

Assuming the rendering change below is due to the banner changes, failed, the main elements (menu, search box etc) have been shifted out of position. If this is down to a previous code change, please identify it, we need to revert.

Dev:

image

Beta:

image

min2ha added a commit that referenced this issue Nov 2, 2017
@ldbiz
Copy link
Collaborator

ldbiz commented Nov 2, 2017

@min2ha that seems to be working. Jason, with you for testing. The link font and text are not quite right and aligned as the design above, but apparently that is going to be a bit of a fiddle so will be deferred via a separate issue for later.

@jasonwebber-bl
Copy link
Collaborator

I'm happy with this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants