Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to default collection images on the server side? #8

Open
anjackson opened this issue Jul 17, 2017 · 1 comment
Open

Switch to default collection images on the server side? #8

anjackson opened this issue Jul 17, 2017 · 1 comment
Assignees
@min2ha
Labels
future-work question

Comments

@anjackson
Copy link
Contributor

anjackson commented Jul 17, 2017 •
edited
Loading

One of a set of questions that arose during an internal code review.

This part of common.js appears to be modifying image tags when there is no image given.

Surely this would be better done server-side? Switching to the default image if none is set? Or is there a reason this can't be done?
@anjackson anjackson mentioned this issue Jul 17, 2017
Open
@anjackson anjackson assigned min2ha and unassigned bzaar May 22, 2018
@anjackson anjackson added this to the 1.2.0 Feature Release milestone May 22, 2018
@anjackson
Copy link
Contributor Author

This to be killed-or-cured on the next release.

@anjackson anjackson removed this from the 1.2.0 Production (MVP) Release milestone Jun 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@min2ha min2ha

Labels
future-work question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@anjackson @bzaar @min2ha