This repository has been archived by the owner on Feb 28, 2023. It is now read-only.
Updated vuejs to v.2.5.23 + storybook 5.0.6 #864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
* Changer la commande d'exécution de node * Ajouter une commande pour rouler storybook sur openshift * Ajouter le paramètre --port à storybook:openshift * mise a jour ts-jest
jomat76
approved these changes
Apr 9, 2019
chuckmah
changed the title
5 tasks
Mboulianne
reviewed
Apr 10, 2019
| @@ -79,10 +80,13 @@ | |||
| "@types/storybook__addon-storyshots": "^3.4.8", | |||
| "@types/storybook__vue": "^5.0.0", | |||
| "@types/webpack-env": "^1.13.6", | |||
| "@vue/test-utils": "^1.0.0-beta.28", | |||
| "@vue/test-utils": "^1.0.0-beta.29", | |||
There was a problem hiding this comment.
Pour ma culture personnelle: Est-ce que finalement ça aidé de passer à vue-test-utils 29?
There was a problem hiding this comment.
Oui méga duper breaking change, important a savoir ->
je vais en parler a la prochaine rencontre UI
There was a problem hiding this comment.
WoW! C'est vraiment intéressant de le savoir! Nous allons justement mettre à jour vue test utils demain à la version 29. C'est un excellent timing!
Mboulianne
reviewed
Apr 10, 2019
| this.calendarState.buildCurrentCalendar() | ||
| ); | ||
| if (this.$scopedSlots) { | ||
| return (this.$scopedSlots as any).default( |
There was a problem hiding this comment.
C'est quoi le type de base des slots ici?
There was a problem hiding this comment.
aucune idee les type on changer dans vue >2.5.18 jai mit ca pour satisfaire la compil si tu as une meilleur idee je suis ouvert au suggestion 👍
jomat76
approved these changes
Apr 10, 2019
fredduguay
approved these changes
Apr 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ulaval/modul-componentsPR Checklist
Mise a jour de storybook et vue au derniere version mineur supporté
La mise a jour de vue a nécessité des changements au niveau du typing typescript. J'ai du ajouter des cast a plusieurs endroit pour enlever les erreurs de compilations.