Fix resize of menuconfig in Python 3 on MacOs #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ulfalizer @kumekay Please take a look. I think this is a sufficient fix. |
|
This looks good and works for me just fine |
ulfalizer
reviewed
Jan 9, 2020
| c = win.get_wch() | ||
| else: | ||
| # curses.error is thrown in Python 3 on MacOs |
There was a problem hiding this comment.
Could change the message to say
# Work around a crash where get_wch() raises curses.error on macOS when
# resizing the terminal, by falling back on getch(). This needs more
# investigation. It doesn't happen on all systems.
See #84 (comment) too. Would be nice to narrow down the configurations that have this issue.
|
Pushed out a release with a fix (same as this one, just with some more comments): 68bcecd Would be nice to figure out and report the root issue at some point though. Thanks. |
ulfalizer
added a commit
to ulfalizer/zephyr
that referenced
this pull request
Jan 13, 2020
Update menuconfig (and kconfiglib and guiconfig, just to sync) to
upstream revision 424d0d38e7, to get this commit in, which works around
a crash on some macOS Python installations.
menuconfig: Work around crash on resize on some macOS systems
get_wch() has started raising curses.error when resizing the
terminal on some macOS Python installations. Work around for now by
falling back on getch(), which still works.
See ulfalizer/Kconfiglib#84. Needs more
investigation, but I don't have a Mac handy.
Based on ulfalizer/Kconfiglib#85, but with
some more comments.
Signed-off-by: Ulf Magnusson <Ulf.Magnusson@nordicsemi.no>
carlescufi
pushed a commit
to zephyrproject-rtos/zephyr
that referenced
this pull request
Jan 13, 2020
Update menuconfig (and kconfiglib and guiconfig, just to sync) to
upstream revision 424d0d38e7, to get this commit in, which works around
a crash on some macOS Python installations.
menuconfig: Work around crash on resize on some macOS systems
get_wch() has started raising curses.error when resizing the
terminal on some macOS Python installations. Work around for now by
falling back on getch(), which still works.
See ulfalizer/Kconfiglib#84. Needs more
investigation, but I don't have a Mac handy.
Based on ulfalizer/Kconfiglib#85, but with
some more comments.
Signed-off-by: Ulf Magnusson <Ulf.Magnusson@nordicsemi.no>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #84