Add meson build setup for C libraries #123
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the possibility to build Ryu with meson. The tests are included too. And a small example as a quick how-to-use. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
|
I'm very sorry, but I won't be able to merge this. Having support for two build systems is already a stretch, but at least I'm fairly familiar with make. I'm hoping that the code here will be upstreamed to various libc / STL implementations and people migrate to using charconv, which will reduce direct use of this code. |
|
All good :-) It was just... to have a counter example how PR for a build system should at least like like imho. Including all platforms, including tests... ;-> And of course you are right, 2 build systems is already quite some burdon; the one that is less used gets out of sync so very quickly. Especially if it's a all-manual-labor like plain make. Thank you for the reply 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the possibility to build Ryu with meson.
The tests are included too.
And a small example as a quick how-to-use.
(Just because I saw that
Makefile-PR and we added meson support quite some time ago already ;)