Fix mantissa overflow for denormal inputs #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The numbers in the test case all should round up to the smallest normalized single-precision number. Previously they were all flushed to zero because rounding up overflows the mantissa and only the lower 23 bits were used. This patch modifies the existing overflow check to also check for the condition described above.
ulfjack
approved these changes
Jun 5, 2020
|
Not sure why Travis didn't post the test results - everything worked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The numbers in the test case all should round up to the smallest normalized
single-precision number. Previously they were all flushed to zero because
rounding up overflows the mantissa and only the lower 23 bits were used.
This patch modifies the existing overflow check to also check for the
condition described above.
NB:
With this patch, the
s2ffunction correctly parses all 9-digit inputs in the form0.00000000e-46,0.00000001e-46, ...9.99999999e+38. (Where correctly is defined as returning the same binary number as the double-conversion library.)