Look for crypto globally instead of window
#73
Conversation
blakeembrey
changed the title
crypto in globally instead of windowcrypto globally instead of window
Codecov Report
@@ Coverage Diff @@
## master #73 +/- ##
=======================================
Coverage 93.08% 93.08%
=======================================
Files 2 2
Lines 246 246
Branches 31 31
=======================================
Hits 229 229
Misses 17 17
Continue to review full report at Codecov.
|
| const browserCrypto = root && (root.crypto || root.msCrypto) | ||
| const webCrypto = root && | ||
| (root.crypto || root.msCrypto) || | ||
| (typeof crypto !== "undefined" ? crypto : null) |
There was a problem hiding this comment.
We could probably just do typeof crypto and typeof msCrypto instead, but I didn't want to break backward compatibility with the root that can currently be passed into this function.
|
I was going to supply the same PR... this is essential if you want to be able to use this with service workers. Any plans to merge this? |
|
Hey, if anyone else finds this issue like I did and is using cloudflare workers, here's what worked for me: import {monotonicFactory} from 'ulid'
// or import {factory} from 'ulid'
const prng = () => {
const buffer = new Uint8Array(1)
crypto.getRandomValues(buffer)
return buffer[0] / 0xff
}
export const ulid = monotonicFactory(prng) // or factory(prng)This will bypass the code that checks for browser crypto and allow you to set your own. The PRNG function is the same as used internally with a different global reference. I think this package may be abandoned, I'm working on potentially forking it. |
Fixes #72.