Skip to content

version-1ceb3b67

Latest
Compare
Choose a tag to compare
@ulimamo ulimamo released this 10 Apr 02:09
· 1 commit to main since this release
4a889f8

commit 1ceb3b6735f7ab7bbb2705816f87180bcbc80cae
Author: Benedikt Meurer bmeurer@chromium.org
Date: Tue Apr 9 18:56:12 2024 +0200

[chai] Use `assert` global provided by `karma-chai`.

This removes the pattern

```js
const {assert} = chai;
```

from our unit test suite, which is fundamentally incompatible with
TypeScript `asserts`, which we intend to put onto Chai assert
functions. And this is also unnecessary, since `karma-chai` (and
also `karma-chai-sinon`) already provide `assert` as a global (with
the proper types).

Bug: 333520272
Change-Id: Id5dfd65903b5b116414709782c7923fc5523e480
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5439575
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>