feat(plugins): fix typing and load-order #29
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ported over the Secretagent plugin fix and noticed that types weren't working here.
I finally got plugin types to work, but it requires the extended classes to not have a default export. I don't think this matters for the end developer - it just matters in the client codebase for Tab, Hero, and I think we'll want to enable extensions for FrameEnvironment.
I toyed with converting other classes, but it seems like we would need to change whole codebase or it feels off.