Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve performance #30

Merged
merged 1 commit into from
May 21, 2021
Merged

feat: improve performance #30

merged 1 commit into from
May 21, 2021

Conversation

blakebyrnes
Copy link
Contributor

This PR improves a few performance issues:

  1. Instead of pre-adding all getters as enumerable, we wait until an element is logged.
  2. State machine now tracks state using a symbol so that it logs with the element, but is clearly internal state
  3. Iterators use plain iterators instead of generators

@calebjclark calebjclark merged commit 1d6e1b6 into master May 21, 2021
@calebjclark calebjclark deleted the perf branch May 21, 2021 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebjclark calebjclark Awaiting requested review from calebjclark

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@blakebyrnes @calebjclark