fix: emulators were failing some double-agent tests

ulixee · Nov 19, 2020 · 5ae4f55 · 5ae4f55
1 parent 240bea6
commit 5ae4f55
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 7 deletions.
diff --git a/client/interfaces/ISecretAgentClass.ts b/client/interfaces/ISecretAgentClass.ts
@@ -4,7 +4,7 @@ import IUserProfile from "@secret-agent/core-interfaces/IUserProfile";
 import ICreateSecretAgentOptions from "./ICreateSecretAgentOptions";
 import ISecretAgent from "./ISecretAgent";
 
-export interface ISecretAgentConfigureOptions extends Pick<ICoreConfigureOptions, 'browserEmulatorIds'> {
+export interface ISecretAgentConfigureOptions extends ICoreConfigureOptions  {
   defaultRenderingOptions: IRenderingOption[];
   defaultUserProfile: IUserProfile;
 }

diff --git a/emulate-browsers/base/injected-scripts/MediaRecorder.isTypeSupported.ts b/emulate-browsers/base/injected-scripts/MediaRecorder.isTypeSupported.ts
@@ -1,7 +1,7 @@
 const { supportedCodecs } = args;
 
 if ((window as any).MediaRecorder) {
-  proxyFunction((window as any).MediaRecorder, 'isTypeSupported', (func, thisArg, type) => {
+  proxyFunction((window as any).MediaRecorder, 'isTypeSupported', (func, thisArg, [type]) => {
     if (type === undefined) return ProxyOverride.callOriginal;
     return supportedCodecs.includes(type);
   });

diff --git a/emulate-browsers/chrome-80/index.ts b/emulate-browsers/chrome-80/index.ts
@@ -46,7 +46,7 @@ export default class Chrome80 {
 
   public readonly userAgent: IUserAgent;
   public readonly networkInterceptorDelegate: INetworkInterceptorDelegate;
-  public locale = 'en-US,en;0.9';
+  public locale = 'en-US,en';
   public userProfile: IUserProfile;
 
   protected domOverrides = new DomOverridesBuilder();

diff --git a/emulate-browsers/chrome-83/index.ts b/emulate-browsers/chrome-83/index.ts
@@ -47,7 +47,7 @@ export default class Chrome83 {
   public readonly userAgent: IUserAgent;
   public readonly networkInterceptorDelegate: INetworkInterceptorDelegate;
 
-  public locale = 'en-US,en;0.9';
+  public locale = 'en-US,en';
   public userProfile: IUserProfile;
 
   protected domOverrides = new DomOverridesBuilder();
@@ -152,9 +152,10 @@ export default class Chrome83 {
         videoCodecs: agentCodecs.videoSupport,
       });
       domOverrides.add('MediaRecorder.isTypeSupported', {
-        supportedCodecs: agentCodecs.audioSupport.recordingFormats.concat(
-          agentCodecs.videoSupport.recordingFormats,
-        ),
+        supportedCodecs: [
+          ...agentCodecs.audioSupport.recordingFormats,
+          ...agentCodecs.videoSupport.recordingFormats
+        ],
       });
       domOverrides.add('RTCRtpSender.getCapabilities', {
         videoCodecs: agentCodecs.webRtcVideoCodecs,