fix: remove console logs, basic emulator bug

ulixee · Jun 28, 2021 · c028062 · c028062
1 parent 9fc446b
commit c028062
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/core/lib/Plugins.ts b/core/lib/Plugins.ts
@@ -52,7 +52,11 @@ export default class Plugins implements IPlugins {
     const BrowserEmulator = Core.pluginMap.browserEmulatorsById[browserEmulatorId];
     if (!BrowserEmulator) throw new Error(`Browser emulator ${browserEmulatorId} was not found`);
 
-    const HumanEmulator = Core.pluginMap.humanEmulatorsById[humanEmulatorId];
+    let HumanEmulator = Core.pluginMap.humanEmulatorsById[humanEmulatorId];
+    // Backwards compatibility for 1.4.X > 1.5.0
+    if (!HumanEmulator && humanEmulatorId === 'basic') {
+      HumanEmulator = Core.pluginMap.humanEmulatorsById[DefaultHumanEmulatorId];
+    }
     if (!HumanEmulator) throw new Error(`Human emulator ${humanEmulatorId} was not found`);
 
     const { browserEngine, userAgentOption } =
@@ -145,7 +149,11 @@ export default class Plugins implements IPlugins {
 
   // PLUGIN COMMANDS
 
-  public async onPluginCommand(sendToPluginId: string, commandMeta: IOnCommandMeta, args: any[]): Promise<any> {
+  public async onPluginCommand(
+    sendToPluginId: string,
+    commandMeta: IOnCommandMeta,
+    args: any[],
+  ): Promise<any> {
     const plugin = this.instanceById[sendToPluginId];
     if (plugin && plugin.onCommand) {
       return await plugin.onCommand(commandMeta, ...args);

diff --git a/plugins/default-browser-emulator/lib/helpers/modifyHeaders.ts b/plugins/default-browser-emulator/lib/helpers/modifyHeaders.ts
@@ -2,7 +2,7 @@ import IResourceHeaders from '@secret-agent/interfaces/IResourceHeaders';
 import { pickRandom } from '@secret-agent/commons/utils';
 import IHttpResourceLoadDetails from '@secret-agent/interfaces/IHttpResourceLoadDetails';
 import BrowserEmulator from '../../index';
-import IBrowserData, { IDataHeaderOrder, IDataHeaders } from "../../interfaces/IBrowserData";
+import IBrowserData, { IDataHeaderOrder, IDataHeaders } from '../../interfaces/IBrowserData';
 
 export default function modifyHeaders(
   browserEmulator: BrowserEmulator,
@@ -133,7 +133,7 @@ function getResourceHeaderDefaults(
   const defaultOrder = defaultOrders.length ? pickRandom(defaultOrders) : null;
 
   if (!defaultOrder) {
-    browserEmulator.logger.error('Headers.NotFound', { resourceType, isSSL, method, originType });
+    browserEmulator.logger.info('Headers.NotFound', { resourceType, isSSL, method, originType });
     return null;
   }