fix(client): allow waiting on resources

ulixee · Feb 2, 2021 · d3414a8 · d3414a8
1 parent aa53e85
commit d3414a8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/client/interfaces/IWaitForResourceFilter.ts b/client/interfaces/IWaitForResourceFilter.ts
@@ -4,5 +4,5 @@ import Resource from '../lib/Resource';
 export default interface IWaitForResourceFilter {
   url?: string | RegExp;
   type?: ResourceType;
-  filterFn?: (resource: Resource, done: () => void) => boolean;
+  filterFn?: (resource: Resource, done: () => void) => Promise<boolean> | boolean;
 }
diff --git a/client/lib/Resource.ts b/client/lib/Resource.ts
@@ -119,9 +119,8 @@ export default class Resource {
         const resource = createResource(resourceMeta, Promise.resolve(coreTab));
 
         if (filter.filterFn) {
-          if (filter.filterFn(resource, done)) {
-            resources.push(resource);
-          }
+          const shouldIncludeResource = await filter.filterFn(resource, done);
+          if (shouldIncludeResource) resources.push(resource);
         } else {
           resources.push(resource);
         }