Services API: Fixes #13106 (memory leak)

ulmus-scott · Aug 20, 2017 · 777965c · 777965c
1 parent 38de2d0
commit 777965c
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/mythtv/programs/mythbackend/services/video.cpp b/mythtv/programs/mythbackend/services/video.cpp
@@ -158,7 +158,7 @@ DTC::VideoMetadataInfo* Video::GetVideoByFileName( const QString &FileName )
 {
     VideoMetadataListManager::metadata_list videolist;
     VideoMetadataListManager::loadAllFromDatabase(videolist);
-    VideoMetadataListManager *mlm = new VideoMetadataListManager();
+    QScopedPointer<VideoMetadataListManager> mlm(new VideoMetadataListManager());
     mlm->setList(videolist);
     VideoMetadataListManager::VideoMetadataPtr metadata = mlm->byFilename(FileName);
 
@@ -169,8 +169,6 @@ DTC::VideoMetadataInfo* Video::GetVideoByFileName( const QString &FileName )
 
     FillVideoMetadataInfo ( pVideoMetadataInfo, metadata, true );
 
-    delete mlm;
-
     return pVideoMetadataInfo;
 }
 
@@ -301,15 +299,13 @@ bool Video::RemoveVideoFromDB( int Id )
 
     VideoMetadataListManager::metadata_list videolist;
     VideoMetadataListManager::loadAllFromDatabase(videolist);
-    VideoMetadataListManager *mlm = new VideoMetadataListManager();
+    QScopedPointer<VideoMetadataListManager> mlm(new VideoMetadataListManager());
     mlm->setList(videolist);
     VideoMetadataListManager::VideoMetadataPtr metadata = mlm->byID(Id);
 
     if (metadata)
         bResult = metadata->DeleteFromDatabase();
 
-    delete mlm;
-
     return bResult;
 }